fix: Local launcher fixes #118
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
…nsys-tools-common into fix/local-launcher-fixes
…nsys-tools-common into fix/local-launcher-fixes
for more information, see https://pre-commit.ci
greschd
reviewed
Nov 27, 2025
| @@ -0,0 +1,37 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
This is an auto-generated file, I think it shouldn't be committed (also applies to some of the other files here).
Member
There was a problem hiding this comment.
Let's add it to the .gitignore
…nsys-tools-common into fix/local-launcher-fixes
for more information, see https://pre-commit.ci
…nsys-tools-common into fix/local-launcher-fixes
for more information, see https://pre-commit.ci
…nsys-tools-common into fix/local-launcher-fixes
greschd
reviewed
Dec 4, 2025
|
|
||
| import requests | ||
|
|
||
| from ansys.tools.local_product_launcher.helpers.ports import find_free_ports |
Member
There was a problem hiding this comment.
These imports should be updated to point to ansys.tools.common.launcher.
greschd
reviewed
Dec 4, 2025
Comment on lines
+19
to
+20
| entry-points."ansys.tools.local_product_launcher.launcher"."example_httpserver.__fallback__" = "example_httpserver_plugin:Launcher" | ||
| entry-points."ansys.tools.local_product_launcher.launcher"."example_httpserver.direct" = "example_httpserver_plugin:Launcher" |
Member
There was a problem hiding this comment.
Suggested change
| entry-points."ansys.tools.local_product_launcher.launcher"."example_httpserver.__fallback__" = "example_httpserver_plugin:Launcher" | |
| entry-points."ansys.tools.local_product_launcher.launcher"."example_httpserver.direct" = "example_httpserver_plugin:Launcher" | |
| entry-points."ansys.tools.common.launcher"."example_httpserver.__fallback__" = "example_httpserver_plugin:Launcher" | |
| entry-points."ansys.tools.common.launcher"."example_httpserver.direct" = "example_httpserver_plugin:Launcher" |
The entrypoint was renamed in #116
@AlejandroFernandezLuces let me know if you want me to help pull forward the changes from that PR into your branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.